-
-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Various fixes in word cloud (spacing, library update, ...) #493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #493 +/- ##
==========================================
+ Coverage 62.02% 62.96% +0.94%
==========================================
Files 59 59
Lines 6199 6265 +66
Branches 809 823 +14
==========================================
+ Hits 3845 3945 +100
+ Misses 2218 2181 -37
- Partials 136 139 +3 |
ajdapretnar
reviewed
Jan 9, 2020
else 0) | ||
input_numbers = f"{cor_output_len or 0}|{n_selected or 0}|{cc_len}" | ||
input_string = f"{cor_output_len or 0} documents\n" \ | ||
f"{n_selected or 0} selected words" \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add line break.
PrimozGodec
force-pushed
the
word-cloud
branch
2 times, most recently
from
January 13, 2020 12:27
56ee7aa
to
d819853
Compare
Comments:
|
PrimozGodec
force-pushed
the
word-cloud
branch
from
January 13, 2020 15:52
d819853
to
20f0c28
Compare
PrimozGodec
force-pushed
the
word-cloud
branch
from
January 13, 2020 18:43
165505a
to
0571798
Compare
Thanks for comments:
|
PrimozGodec
force-pushed
the
word-cloud
branch
from
January 13, 2020 19:00
0571798
to
cabaf6f
Compare
PrimozGodec
changed the title
[WIP] Various fixes in word cloud (spacing, library update, ...)
Various fixes in word cloud (spacing, library update, ...)
Jan 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #399
Fixes #225
Fixes #390 as much as possible
Description of changes
With this PR I made various fixes in the word cloud widget:
TODO:
Includes